fix(app): enable terminal on draft sessions#33120
Draft
anduimagui wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33119
Type of change
What does this PR do?
Enables the existing embedded terminal panel on the
/new-sessiondraft route.The draft route now mounts
TerminalProvider, derives the session layout/terminal workspace key from the draft SDK directory when there is no:dirroute param, renders the existingTerminalPanel, and registersterminal.toggle/terminal.newwhile the draft page is mounted.This keeps normal session routing behavior unchanged while allowing the desktop View -> Toggle Terminal path to work before the draft is promoted into a real session.
How did you verify your code works?
bun typecheckfrompackages/appbun testfrompackages/app(407 pass)bun turbo typechecksuccessfullyScreenshots / recordings
Not captured yet; opening as a draft so a visual check can be added before marking ready.
Checklist